The problem was not immediately obvious to me: after eliminating dtrace(1)
output filename clash and forcibly serializing two normally concurrent in
parallel mode linking stages, the problem did not go away. In fact, while
the port was building seemingly fine in a single-thread (unsafe) mode, the
messages "No probe sites found for declared provider" were still sometimes
present in the log, as well as "target object (...) already exists. Please
remove the target object and rebuild all the source objects if you wish to
run the DTrace".
Running dtrace(1) via truss(1) revealed something odd: it was opening the
substrate object files in read-write mode! Further tests and studying its
code (/usr/src/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c;
see process_obj() and dt_modtext() functions) had confirmed that it is not
idempotent, and under certain circumstances would actually modify object
files passed to it.
Address the problem in the following ways: 1) append PID number to the
output file name to reduce the chances of clash; 2) most importantly, copy
the object files to a temporary location before allowing dtrace(1) to mess
with them.
This is rather ugly and far from robust solution; however, even that the
port does not break in single-thread build mode for some reason, dtrace(1)
rightfully generates errors (ir)regardless. Ultimately, I'd rather see
dtrace(1) fixed properly instead so this work-around could be dropped.
port's inception as of version 2.6.2, however, it was neither present in
submitted PR nor explained in the original commit log by pi@. So far my
quick tests do not show evidence that it is parallel-build unsafe.
We'll ask for forgiveness if it is indeed broken against -j X builds and
reinstate MAKE_JOBS_UNSAFE, but with a proper explanation this time.
While here, remove needless += from CMAKE_ARGS and place them at a better
location within the Makefile.
PR: 205377
This is the C client library for Couchbase. It communicates with the cluster
and speaks the relevant protocols necessary to connect to the cluster and
execute data operations.
https://github.com/couchbase/libcouchbase/
PR: 205377
Submitted by: gebhart@secnetix.de, Sergey Avseyev <sergey.avseyev@gmail.com>
