I checked linrad upstream, and they still haven't fixed these two bugs. I am surprised they haven't been reported yet. Without these fixes, linrad cannot be built with gcc5.
the menu.c patch simply reverses the order of the condition. One must check the bounds constraint first! It's a pretty dumb mistake but I've seen this kind before.
The second one fails because -Werror is set. This took me a while because I couldn't figure out the relationship between ADCHANS and rxchan. In any case, setting 4 locations per channel did indeed allow the array to be big enough. (at first I thought the loop was running too high, but I finally determined the array was too small).
These were found on DragonFly that uses gcc5.
This patch has not been tested on FreeBSD but I can't how it could possibly fail.
It would be good if the ham@ maintainer reports the issue upstream.
Updated patch files using make makepatch
PR: ports/199737
Submitted by: marino
trying to link with libalsa.so. When it was detected, resulted in linking
with a non-dependant lib.
If there is enough demand, I can add OPTS for ALSA vs portaudio etc, but for
now just a hard dependency on portaudio will be enough.
Linrad-04.02 comes with many improvements. The first FFT can now run in
parallel in up to 6 separate threads. More efficient FFT implementations
are available for some hardware architectures.
The converter option is corrected.
Several bug corrections.
- Remove USE_XLIB/USE_X_PREFIX/USE_XPM in favor of USE_XORG
- Remove X11BASE support in favor of LOCALBASE or PREFIX
- Use USE_LDCONFIG instead of INSTALLS_SHLIB
- Remove unneeded USE_GCC 3.4+
Thanks to all Helpers:
Dmitry Marakasov, Chess Griffin, beech@, dinoex, rafan, gahr,
ehaupt, nox, itetcu, flz, pav
PR: 116263
Tested on: pointyhat
Approved by: portmgr (pav)
Diane Bruce
Stephen Hurd
Martin Wilke
Frank J. Laszlo
Ion-Mihai Tetcu
Shaun Amott
Marcus Alves Grando
Pav Lucistnik