260b5ad90f
Integrates several backported patches from different origins, with some aligning with those chosen for the Ubuntu ipmitool package while awaiting upstream inclusion. These patches address: - [open interface] Eliminate buffer overrun - [dcmi] Update parameters to read temperature sensors - [fru] Update the fru section offset only when they exist - [fru] Adjust the fru section by their offset order - [lan] Fix error response from Unsupported Parameter lookup - [lan] Fix lan print fails on unsupported parameters - [sdr] Fix sensor reading - [sdr] Fix command ipmitool sdr type with raw values PR: 282617 Approved by: zi (maintainer) Sponsored by: Netflix
37 lines
1.3 KiB
Plaintext
37 lines
1.3 KiB
Plaintext
From 137aeb64cbb493d61d6945cac156aba5f0510780 Mon Sep 17 00:00:00 2001
|
|
From: Miao Wang <shankerwangmiao@gmail.com>
|
|
Date: Sat, 10 Feb 2024 12:51:15 +0800
|
|
Subject: [PATCH] lan: fix lan print fails on unsupported parameters
|
|
|
|
After upgrading to ipmitool 1.8.19, ipmitool lan print can only print out
|
|
`Set in Progress` and other parameters are missing on our servers. After
|
|
bisecting, commit:
|
|
|
|
351dad24a26f lan: Add processing of get/set specific CCs
|
|
|
|
is identified to be the source of the problem, where the function
|
|
get_lan_param_select is expected to consider severial error codes it
|
|
receives as empty response. It then constructs an empty response in `p`
|
|
and assigns `p` to `rc` and the control flow falls through to the
|
|
default case, which prints the error code in verbose mode and should
|
|
return `rc` instead of `NULL`.
|
|
|
|
Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
|
|
---
|
|
lib/ipmi_lanp.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git lib/ipmi_lanp.c lib/ipmi_lanp.c
|
|
index fe0046f..26e7365 100644
|
|
--- lib/ipmi_lanp.c
|
|
+++ lib/ipmi_lanp.c
|
|
@@ -245,7 +245,7 @@ get_lan_param_select(struct ipmi_intf *intf, uint8_t chan, int param, int select
|
|
specific_val2str(rsp->ccode,
|
|
get_lan_cc_vals,
|
|
completion_code_vals));
|
|
- return NULL;
|
|
+ return rc;
|
|
}
|
|
|
|
p->data = rsp->data + 1;
|