freebsd/ports
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mail/fetchmail: Fix shell's 'Bad -c option' in rcscript.

Browse Source 
Turns out that our fetchmail_dump_config() function needs to add
one more level of quoting because it's being unquoted and word split
twice, once by su's shell, and again by sh.

While here, change sh to /bin/sh to make the intention clearer.

Bump PORTREVISION to get the fix out onto the systems.

PR:		250691
Reported by:	Helmut Ritter <freebsd-ports@charlieroot.de>
Approved by:	chalpin@cs.wisc.edu
MFH:		2020Q4 (blanket, one-line tested working fix, 4-eyes principle)
This commit is contained in:
Matthias Andree
2020-11-01 19:38:58 +00:00
parent 4ec963be46
commit b03fc003c7
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mail/fetchmail/Makefile
View File

@@ -3,7 +3,7 @@
PORTNAME?= fetchmail
DISTVERSION= 6.4.12
PORTREVISION?= 2
PORTREVISION?= 3
CATEGORIES= mail
# The next line is inherited by the fetchmailconf slave port,
# do NOT replace fetchmail by ${PORTNAME}

2
mail/fetchmail/files/fetchmail.in
View File

@@ -116,7 +116,7 @@ fetchmail_awaken()
# query a value from the fetchmail config file, value specified in first argument
fetchmail_dump_config()
{
su -m ${fetchmail_user} -c sh -c "fetchmail -f ${fetchmail_config} --configdump" | fgrep $1 | cut -d: -f2
su -m ${fetchmail_user} -c "/bin/sh -c 'fetchmail -f ${fetchmail_config} --configdump'" | fgrep $1 | cut -d: -f2
}
# arguments: